feat: add support for enabling ORDER BY on non projected columns #1155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to PR #1147, we've introduced support for the use of ORDER BY on non-projected columns
The following query won't work.
Select name AS n FROM meme_images ORDER BY n;
Currently, we execute projection as the last operation. Only when a function expression is present it is executed before projection, allowing its use in ORDER BY. A complete fix will require us to redesign the binder. Right now, we've decided to defer this task because there is no urgency to support it.
Ref: https://github.com/duckdb/duckdb/blob/52a47a6b311a8aa008e7c78d8472eb52a937fa62/src/planner/expression_binder/order_binder.cpp#L68