Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible hypop doesn't remove kwargs at default #83

Closed
AlessandroLovo opened this issue Jan 3, 2024 · 1 comment
Closed

flexible hypop doesn't remove kwargs at default #83

AlessandroLovo opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@AlessandroLovo
Copy link
Collaborator

flexible_hypop.py directly calls

self.trainer._run(**run_args)

which means that the check and removal of arguments at their default value is not performed.
This is a minor bug, which simply affects how the runs.json file looks.

Possible solutions are:

  1. to perform the argument check in the _run function of the Trainer class
  2. Manually remove args at default in flexible hypop
  3. Do nothing
@AlessandroLovo AlessandroLovo added the bug Something isn't working label Jan 3, 2024
@AlessandroLovo AlessandroLovo self-assigned this Jan 3, 2024
AlessandroLovo added a commit that referenced this issue Jan 3, 2024
AlessandroLovo added a commit that referenced this issue Jan 3, 2024
@AlessandroLovo
Copy link
Collaborator Author

Went with option 1

AlessandroLovo added a commit that referenced this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant