Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible latitude in committor_projection_NN.py #45

Closed
AlessandroLovo opened this issue Jan 24, 2023 · 1 comment
Closed

Flexible latitude in committor_projection_NN.py #45

AlessandroLovo opened this issue Jan 24, 2023 · 1 comment
Assignees
@AlessandroLovo
Labels
enhancement New feature or request

Comments

@AlessandroLovo
Copy link
Collaborator

Right now the latitude used for regularization is hardcoded. This is bad for generalization. We need to get it from the fields passing through all the functions up to where it needs to go.

A possibility is to add a tunnel argument that is simply passed through all the functions in the main Learn2_new code that helps for inheritance
@AlessandroLovo AlessandroLovo added the enhancement New feature or request label Jan 24, 2023
@AlessandroLovo AlessandroLovo self-assigned this Jan 24, 2023
AlessandroLovo added a commit that referenced this issue Jan 24, 2023
@AlessandroLovo
Tackling #45
2cbd28c
@AlessandroLovo
Copy link
Collaborator Author

Solved with module-level variable instead of tunneling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlessandroLovo AlessandroLovo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlessandroLovo