Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds get to client to download specific URL from Salesforce #4

Closed
wants to merge 2 commits into from

Conversation

brberry
Copy link
Contributor

@brberry brberry commented Apr 27, 2024

Adds get method to client to download specific URL from Salesforce, useful for downloading EventLogFile records.

Event Log Overview: https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/using_resources_event_log_files.htm

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.44%. Comparing base (680593b) to head (9b18e05).

Files Patch % Lines
src/aiosalesforce/client.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   82.70%   82.44%   -0.26%     
==========================================
  Files          26       26              
  Lines        1220     1225       +5     
==========================================
+ Hits         1009     1010       +1     
- Misses        211      215       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgebv
Copy link
Owner

I'll have to reject this one. Client is intended to be high level and to provide interface to specific APIs. If you need to make a custom HTTP request you can do so using client.request already. I don't see value in adding methods for individual HTTP verbs.

@georgebv georgebv closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants