ISSUE-198 - Reorganization of the plot of land interface, in particular for waste garbage cans

[LPoin]

Multiple changes to the parcel search interface:

• the ‘+’ button is now placed after the tabs used to search for plots, like a web browser.
• tab deletion is now done by a cross on each tab. The dustbin has been removed.
• the ‘search’ and ‘delete’ buttons have been grouped together in the plot search block to avoid confusion with the plot selection block below.

These changes have been reflected in the search for owners and co-owners to maintain the overall consistency of cadastrapp.

Tested in integration.
Mapstore 2023.02
Node 16.20.2

[landryb]

deployed locally, renders like this:

strangely i cant select plots anymore in the search results. i can doubleclick on the plot line and it opens the info form, i can tick the 'select all' box, but the box on the plot line is inactive. thus i cant select the plot line to test the trash...

creating a new empty selection tab 2, coming back to the selection 1 tab and clicking on the cross to close selection tab 2 destroys the wrong selection tab (ie tab1, the one where i had a plot from a map selection)

[LPoin]

Both issues have been fixed.

[landryb]

It's better, but there's still an UX annoyance: if you close a tab which isnt displayed/selected, after confirming, you get a blank area, and you need to reselect the previously selected tab, while it shouldn't stop showing the currently selected tab..

[pierrejego]

It's better, but there's still an UX annoyance: if you close a tab which isnt displayed/selected, after confirming, you get a blank area, and you need to reselect the previously selected tab, while it shouldn't stop showing the currently selected tab..

This is a regression, it was working on previous version. This point has to be corrected before merging

[Gaetanbrl]

You can also (other solution) just pass the delete func as property to reduce function complexity:

<DeletePlot delete={() => onTabDelete(index + (MAX_TABS - 1))}/>

Function :

function DeletePlot ({
    delete = () => {},
}) {    
    return (
        <OverlayTrigger placement="bottom" overlay={<Tooltip><Message msgId={'cadastrapp.search.deleteTab'}/></Tooltip>}>
            <ConfirmButton
                href="javascript:void(0)"
                confirmContent={<Message msgId={'cadastrapp.search.confirmDeleteTab'}/>}
                onClick={(e) => {
                    e.stopPropagation();
                    delete();
                    }}>
                <Glyphicon glyph="remove" />
            </ConfirmButton>
        </OverlayTrigger>
    )
}

[Gaetanbrl]

Minor not required change