fix search by owner id/lot #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove an hardcoded SEARCH_TYPE.USER that was added in georchestra#127.
dsuren1
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove an hardcoded SEARCH_TYPE.USER that was added in #127. This PR fixes #154 for me.
I'm now sure #154 is a regression from #127 which fixed #123. If i use
currentTabinstead of the hardcodedSEARCH_TYPES.USERin https://github.com/georchestra/mapstore2-cadastrapp/blob/master/js/extension/components/search/OwnersSearch.jsx#L49 - then owner search by id works.@offtherailz can you have a look at that regression and fix all cases ? Will do a PR with my local change but i'm not sure it covers all of them.
Sadly it seems all usecases weren't properly tested in #127.