Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#141: Allow text selection from react grid cell #148

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

dsuren1
Copy link
Collaborator

@dsuren1 dsuren1 commented Jan 26, 2022

Description

This PR allows possibility to select texts from react grid cells

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#141

What is the new behavior?
User can now click and drag/double click on grid cell to select a text

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 requested a review from offtherailz January 26, 2022 13:39
@dsuren1 dsuren1 self-assigned this Jan 26, 2022
Copy link
Collaborator

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be applied to the whole mapstore. Can you please create a more specific selector that includes only the tables of cadastrapp, in order to avoid possible issues caused by the inclusion of this plugin.

@dsuren1
Copy link
Collaborator Author

dsuren1 commented Feb 22, 2022

Sure

@dsuren1 dsuren1 requested a review from offtherailz February 22, 2022 14:03
@offtherailz offtherailz merged commit 6dc4791 into georchestra:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants