Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProConnect - store SIRET in new uniqueOrganisationId field #159

Open
Gaetanbrl opened this issue Dec 18, 2024 · 3 comments
Open

ProConnect - store SIRET in new uniqueOrganisationId field #159

Gaetanbrl opened this issue Dec 18, 2024 · 3 comments

Comments

@Gaetanbrl
Copy link

Gaetanbrl commented Dec 18, 2024

Context

As part of ProConnect developments,

The SIRET value return by ProConnect will be use as unique value to compare / search / identify an org.

Currently, not LDAP fields exists to store or use the SIRET value.

Description

A new LDAP field needs to be created to use SIRET value.

We plan to create a new Numeric String field with the name uniqueOrganisationId.

About Numeric String type : https://docs.ldap.com/specs/rfc4517.txt

To use this field, we needs to change the console UI to be able to write SIRET or other organization ID value (e.g association official number or foreign org identifier).

@Gaetanbrl Gaetanbrl changed the title ProConnect - store SIRET in new idOrganisation field ProConnect - store SIRET in new idOrganization field Dec 18, 2024
@Gaetanbrl
Copy link
Author

Gaetanbrl commented Dec 24, 2024

We plan to create a new Numeric String field with the name idOrganization.

After some discussion wiht @pierrejego and @landryb , it seems better to use a string type instead Numeric.

@Gaetanbrl
Copy link
Author

This issue needs to be move into georchestra/georchestra with LDAP tag

@landryb
Copy link
Member

landryb commented Dec 26, 2024

seems better to use a string type instead Numeric.

the rationale is simple: even if in france SIRET codes are numeric only, we'll never know what kind of unique identifiers can be used in other countries (hex guid with dashes, uppercase characters..), and other countries might have a similar national auth service implementing standard protocols...

@Gaetanbrl Gaetanbrl changed the title ProConnect - store SIRET in new idOrganization field ProConnect - store SIRET in new uniqueOrganisationId field Dec 26, 2024
Gaetanbrl added a commit to jdev-org/georchestra that referenced this issue Jan 6, 2025
…rchestra/georchestra-gateway#159

Add organizationId object

Fix olcAttribute type uniqueOrganizationId

Console - new form field - uniqueOrganizationId

Custom proconnect tag for docker image

ldap management - add new uniqueOrganizationId

up attribute and add siret c2c info

new uniqueOrganizationId field in orgDao
Gaetanbrl added a commit to jdev-org/georchestra that referenced this issue Jan 6, 2025
…rchestra/georchestra-gateway#159

Add organizationId object

Fix olcAttribute type uniqueOrganizationId

Console - new form field - uniqueOrganizationId

Custom proconnect tag for docker image

ldap management - add new uniqueOrganizationId

up attribute and add siret c2c info

new uniqueOrganizationId field in orgDao

console, ldap - add new orgUniqueId field

use organizatioid

change jsp new account

new code insertion for field uniqueOrganizationId

org create form translation

Fix app. properties with uniqueOrganizationId

translate missing key

use standard var name

rename new org field according to console rules

Fix JSON var name

fix getter annotation

add missing new file

Insert new orgUniqueId field in commons

New field Mapping with organization class

fix around new orgUniqueId field

Changes around new orgUniqueId ldap field

Fix JSP error

remove useless console log

Add new account orgUniqueId field

complete code with new org field

Control orgUniqId unicity before save, update

fix org validation by orgUniqueId field

correct makefile btag
Gaetanbrl added a commit to jdev-org/georchestra that referenced this issue Jan 8, 2025
…georchestra/georchestra-gateway#159

sec-proxy-spring-integ - method to get org by field orgUniqueId

Reverse console package-lock

Fix & valide console tests

Change way to validate org unicity

console - use mvn formatter

console - change test
Gaetanbrl added a commit to jdev-org/georchestra that referenced this issue Jan 8, 2025
…rchestra/georchestra-gateway#159

Add organizationId object

Fix olcAttribute type uniqueOrganizationId

Console - new form field - uniqueOrganizationId

Custom proconnect tag for docker image

ldap management - add new uniqueOrganizationId

up attribute and add siret c2c info

new uniqueOrganizationId field in orgDao

console, ldap - add new orgUniqueId field

use organizatioid

change jsp new account

new code insertion for field uniqueOrganizationId

org create form translation

Fix app. properties with uniqueOrganizationId

translate missing key

use standard var name

rename new org field according to console rules

Fix JSON var name

fix getter annotation

add missing new file

Insert new orgUniqueId field in commons

New field Mapping with organization class

fix around new orgUniqueId field

Changes around new orgUniqueId ldap field

Fix JSP error

remove useless console log

Add new account orgUniqueId field

complete code with new org field

Control orgUniqId unicity before save, update

fix org validation by orgUniqueId field

correct makefile btag

ldap, console: new field orgUniqueId georchestra#4374 georchestra#4372 georchestra/georchestra-gateway#159

sec-proxy-spring-integ - method to get org by field orgUniqueId

Reverse console package-lock

Fix & valide console tests

Change way to validate org unicity

console - use mvn formatter

console - change test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants