Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the right URL for 'forgot password' link #3

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

landryb
Copy link
Member

@landryb landryb commented Jan 11, 2022

TBD: testing, + adding the 'create account' link.

@pmauduit pmauduit requested a review from tkohr January 11, 2022 14:14
@landryb
Copy link
Member Author

landryb commented Jan 11, 2022

image

both links point to the right georchestra-specific urls.

(yeah i know i hardcoded 'créer un compte' but that would mean readding strings to message.properties files which arent in the repo...)

@landryb
Copy link
Member Author

landryb commented Jan 11, 2022

image

is the result with my last commits

Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and sends to correct URLs. Thanks @landryb !

Just a bit of a shame, as you mentioned, that we end up with a mixed language template and no english translation for "S'inscrire". Could it be an alternative to just set a translation key in this PR and set its values (for FR and EN) in https://github.com/georchestra/georchestra/tree/master/cas-server-webapp/src/main/resources?

@landryb
Copy link
Member Author

landryb commented Jan 13, 2022

Could it be an alternative to just set a translation key in this PR and set its values (for FR and EN) in https://github.com/georchestra/georchestra/tree/master/cas-server-webapp/src/main/resources?

well i dunno how the translations/resources would merge/override the other ones shipped inside cas6 (which arent the ones you link to), so i didnt explore this. Left as an exercise to the next one working on cas6 :)

@tkohr tkohr mentioned this pull request Jan 13, 2022
@tkohr
Copy link
Contributor

tkohr commented Jan 13, 2022

Hum, yep kind of difficult to test the translation behavior from here.

I added a small PR adapting the login UI on top of this one. Feel free to comment!

@fvanderbiest fvanderbiest merged commit f338ae8 into master Jan 14, 2022
@pmauduit pmauduit deleted the pass-link branch February 15, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants