-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the right URL for 'forgot password' link #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and sends to correct URLs. Thanks @landryb !
Just a bit of a shame, as you mentioned, that we end up with a mixed language template and no english translation for "S'inscrire". Could it be an alternative to just set a translation key in this PR and set its values (for FR and EN) in https://github.com/georchestra/georchestra/tree/master/cas-server-webapp/src/main/resources?
well i dunno how the translations/resources would merge/override the other ones shipped inside cas6 (which arent the ones you link to), so i didnt explore this. Left as an exercise to the next one working on cas6 :) |
Hum, yep kind of difficult to test the translation behavior from here. I added a small PR adapting the login UI on top of this one. Feel free to comment! |
TBD: testing, + adding the 'create account' link.