Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specifying unit (px) to the header height (#10) #11

Merged
merged 1 commit into from
May 2, 2022
Merged

specifying unit (px) to the header height (#10) #11

merged 1 commit into from
May 2, 2022

Conversation

pmauduit
Copy link
Member

@pmauduit pmauduit commented May 2, 2022

Title says it all, see also #10 for the motivation.

tkohr
tkohr approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmauduit! If I understand right, header height is always expressed in px in the datadir !?

@pmauduit
Copy link
Member Author

pmauduit commented May 2, 2022

Thanks @pmauduit! If I understand right, header height is always expressed in px in the datadir !?

yes: https://github.com/georchestra/datadir/blob/master/default.properties#L31-L34

@pmauduit pmauduit merged commit 49321aa into master May 2, 2022
@pmauduit pmauduit deleted the missing-header-height-unit-10 branch May 2, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmauduit @tkohr