Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD/RLS: update wheels to include GDAL 3.8.3 #347

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

jorisvandenbossche
Copy link
Member

Closes #340

Like #298, now updating to GDAL 3.8.3 (microsoft/vcpkg@6df4d4f)

@jorisvandenbossche
Copy link
Member Author

It's always "fingers crossed" when updating the wheel building, but it seems that this worked from the first try! ;)

@brendan-ward
Copy link
Member

Thanks for working on this @jorisvandenbossche !

What do you think about making this a new minor version instead of a patch release? (meaning: 0.8.0 instead of 0.7.3) I think in general we've tried to make a minor version upgrade of GDAL in the wheels a minor version upgrade on our end.

In terms of order of operations, would it be better to get #323 in place for the updated actions, or get this PR out before merging that?

@jorisvandenbossche
Copy link
Member Author

Yes, I was thinking the same. I was planning to open an issue, but then thought to just discuss this in the geopandas meeting. I was also thinking doing a 0.8.0 because generally we shouldn't bump GDAL (except for bug fixes) in a bug-fix release. We only don't really have other "features" to release for 0.8.0 apart from a new GDAL version, though. But maybe that doesn't really matter 🤷

I don't think it matters which PR goes first (and there shouldn't be much conflicts), so feel free to merge yours first.

And it seems windows is still occasionally crashing at clean up

@jorisvandenbossche jorisvandenbossche merged commit e6e6e42 into geopandas:main Jan 25, 2024
46 checks passed
@jorisvandenbossche jorisvandenbossche deleted the wheels-gdal-3.8 branch January 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: Upgrade VCPKG GDAL to 3.8.3
2 participants