ENH: read DateTime fields with millisecond accuracy #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-ward
reviewed
Jun 2, 2022
brendan-ward
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Thanks @jorisvandenbossche !
Should we add a note to known_issues.md that datetime is only supported at a millisecond resolution, even though it is later cast to datetime64[ns] when read into a data frame?
|
I added a small note. That could then be updated when support for writing is added (to also indicate that sub-millisecond values will be lost) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the geopandas tests. WIP: I still need to add a test for this (but because we don't yet have support for writing datetimes, that's a bit harder)