Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyGEOS support, require Shapely 2+ #280

Merged
merged 7 commits into from
Mar 16, 2024

Conversation

jorisvandenbossche
Copy link
Member

We don't actually have that much of code complexity from supporting both (at least not compared to pandas, because we mostly dispatch to the geopandas methods), but it does complicate testing a bit (e.g. when tests fail for pygeos), and generally I think shapely 2.0 is widely supported nowadays and already out for more than a year.

@TomAugspurger
Copy link
Contributor

Thoughts on adding shapely>=2 to the dependencies in pyproject.toml? I suppose we get shapely through geopandas, but probably best to state it explicitly so that users don't need an ImportError to discover that their version isn't valid.

@martinfleis
Copy link
Member

If there are multiple geometry columns, are they guaranteed to have the same CRS? It seems like there's a CRS on the table but not a GeoSeries.

Yeah, we need that as the min geopandas is 0.12 which does not enforce shapely 2.

@jorisvandenbossche
Copy link
Member Author

Good point to add shapely, done!

@TomAugspurger
Copy link
Contributor

+1. The doc build failure looks related to dask-expr, which is being handled elsewhere.

@jorisvandenbossche jorisvandenbossche merged commit 3489a1c into geopandas:main Mar 16, 2024
11 of 13 checks passed
@jorisvandenbossche jorisvandenbossche deleted the remove-pygeos branch March 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants