Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E test failures #960

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Fix E2E test failures #960

merged 4 commits into from
Aug 13, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Aug 13, 2024

Description

This PR tweaks E2E tests further. Issues fixed are:

  • sometimes the custom thesauri (GEMEt and INSPIRE themes) in the init step were pushed to GN, but then the thesauri would be reset and the "regions" thesauri would be pushed instead; I added a delay before pushing the custom thesauri and it always works now!
  • I also added a print of the indexation errors happening in the init step, so that we can make sure that indexation happens exactly like it does locally (it wasn't the case before the above change)
  • I added a dependency from the metadata-editor E2E to datahub E2E because if the editor tests pass first they change the records so that the datahub tests will fail after that; obviously this is not ideal (it shows that the datahub tests are too sensitive) but we can live with that for now

Architectural changes

none

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Affected libs: feature-map, feature-dataviz, feature-record, feature-router,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Aug 13, 2024

📷 Screenshots are here!

@jahow jahow force-pushed the fix-e2e-test-again branch from 2ba6aa5 to 42c124e Compare August 13, 2024 10:05
@jahow jahow changed the title fix(map): avoir error when computing record extent with geom Fix E2E test failures Aug 13, 2024
@coveralls
Copy link

coveralls commented Aug 13, 2024

Coverage Status

coverage: 84.145% (+1.2%) from 82.94%
when pulling 4314f0c on fix-e2e-test-again
into caf9e4e on main.

@jahow jahow force-pushed the fix-e2e-test-again branch 5 times, most recently from 9ad92e0 to 307ef99 Compare August 13, 2024 12:41
jahow added 2 commits August 13, 2024 14:52
This will avoid the thesauri to somehow be wiped (??) during GN init, thus
making subsequent E2E fail
@jahow jahow force-pushed the fix-e2e-test-again branch from 307ef99 to 4314f0c Compare August 13, 2024 12:52
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix the e2e test!

@jahow jahow merged commit 618ec56 into main Aug 13, 2024
11 checks passed
@jahow jahow deleted the fix-e2e-test-again branch August 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants