-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E test failures #960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected libs:
|
📷 Screenshots are here! |
2ba6aa5
to
42c124e
Compare
9ad92e0
to
307ef99
Compare
This will avoid the thesauri to somehow be wiped (??) during GN init, thus making subsequent E2E fail
307ef99
to
4314f0c
Compare
LHBruneton-C2C
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to fix the e2e test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks E2E tests further. Issues fixed are:
init
step were pushed to GN, but then the thesauri would be reset and the "regions" thesauri would be pushed instead; I added a delay before pushing the custom thesauri and it always works now!init
step, so that we can make sure that indexation happens exactly like it does locally (it wasn't the case before the above change)Architectural changes
none
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label