Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Datahub]: Map keyword link to key #937

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix [Datahub]: Map keyword link to key #937

merged 1 commit into from
Jul 15, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jul 10, 2024

Description

The PR maps the ES keyword.link from allKeywords to gn-ui's Keyword.key, which we forgot in #811 I think. This is necessary to allow updating search (filters) using the key.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Affected libs: api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, feature-auth, ui-search,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Jul 10, 2024

📷 Screenshots are here!

@tkohr
Copy link
Collaborator Author

tkohr commented Jul 10, 2024

Wondering if it would make sense to rename Keyword.key to Keyword.uri. Are they always URIs?

@coveralls
Copy link

Coverage Status

coverage: 83.615% (-1.5%) from 85.088%
when pulling c674335 on keyword-key
into cec60ff on main.

Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍 Thanks!

@cmoinier cmoinier merged commit e77c0f8 into main Jul 15, 2024
9 checks passed
@cmoinier cmoinier deleted the keyword-key branch July 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants