e2e(datahub): wait more precisely for favorite to be registered #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that the filtering on favorites was sometimes done too early
|
Affected libs:
|
|
📷 Screenshots are here! |
tkohr
approved these changes
Apr 9, 2024
| @@ -1,6 +1,7 @@ | |||
| <div class="flex flex-row items-center"> | |||
| <span | |||
| class="align-text-top mr-1.5 favorite-count" | |||
| class="align-text-top mr-1.5" | |||
| data-test="favorite-count" | |||
There was a problem hiding this comment.
We are already using data-cy in other locations. Maybe it's worth to name it the same. Then again I see it's also used in the UTs, so I let you judge :-)
There was a problem hiding this comment.
exactly, it used in the UT so I gave priority to data-test :)
|
Thanks for the quick review!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that the filtering on favorites was sometimes done too early