Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing translations for DE/FR/IT #836

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Added missing translations for DE/FR/IT #836

merged 1 commit into from
Mar 25, 2024

Conversation

ronitjadhav
Copy link
Collaborator

This PR includes updates to the German (DE), Italian (IT), and French (FR) translations.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@ronitjadhav ronitjadhav requested a review from jahow March 25, 2024 11:17
@github-actions GitHub Actions
Copy link
Contributor

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@ronitjadhav ronitjadhav requested review from tkohr and Angi-Kinas March 25, 2024 11:19
jahow
jahow approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Angi-Kinas
Angi-Kinas approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ronitjadhav ronitjadhav merged commit be693a5 into main Mar 25, 2024
7 checks passed
@ronitjadhav ronitjadhav deleted the DH-add-missing-translations branch March 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angi-Kinas Angi-Kinas Angi-Kinas approved these changes

@jahow jahow jahow approved these changes

@tkohr tkohr Awaiting requested review from tkohr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronitjadhav @jahow @Angi-Kinas