Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: Add default baselayer to map when no mapConfig exists #822

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Mar 14, 2024

Description

This PR adds the default baselayer to the map even if no mapConfig exists. This case can occur in particular in custom applications without a config.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Copy link
Contributor

Affected libs: feature-map, feature-dataviz, feature-record, feature-router,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 85.619% (+2.3%) from 83.342%
when pulling 796704d on basemap-no-config
into 1189d39 on main.

Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for the work ! 😄

@tkohr tkohr merged commit 95b40cd into main Mar 14, 2024
9 checks passed
@tkohr tkohr deleted the basemap-no-config branch March 14, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants