-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Editor: rework search results layout, add "create record" button #805
Conversation
The component now only contains the interactive table
Affected libs:
|
This resolves a technical debt item that was waiting for a move to rxjs 7
57b74f2
to
1722551
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great work!
<h1 class="text-[16px] text-main font-title font-bold" translate> | ||
dashboard.records.all | ||
</h1> | ||
<div class="text-[12px]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind for gap, padding, margin, but should text size be hardcoded in pixels this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I always hardcode pixel values like that now, then there's no need to look for the meaning of e.g. text-sm
in pixels (also many TW classes use rem
instead of px
which is one more annoying thing when working with precise mockups).
I don't see any drawbacks to this personally, do you think this could be an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends, do you intend to be responsive when people change there screen size, zoom in/out?
I honestly don't know how Tailwind CSS behaves in those cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TW has modifiers for screen sizes so there's really no impact here 🙂
edit: https://tailwindcss.com/docs/responsive-design
apps/metadata-editor/src/app/records/search-records/search-records-list.component.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed because it wasn't working and it basically needs a whole application to run, which doesn't really make sense in the context of storybook anymore
Thanks for the review! |
Description
This PR affects the layout of the search results in the dashboard views of the editor:
/records/all
, only keep/records/search
route (similar to the datahub)RecordsCountComponent
class to extract the part that shows the amount of records and selected records in the tableCreatePageComponent
, nowEditComponent
is used both for editing and creatingArchitectural changes
Add
ngx-translate-testing
dependency (instead of a local copy of the lib that was introduced while waiting for rxJS 7)Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label