Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map-Viewer] Added a geocoding text field #791

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

ronitjadhav
Copy link
Collaborator

@ronitjadhav ronitjadhav commented Feb 2, 2024

Description

This PR introduces a geocoding text field to the Map Viewer application. It functions as a search input, complete with a search icon, debounce functionality, and a clear button that appears when text is entered.

  • Added a geocoding text field to the Map Viewer interface.
  • Implemented a search icon within the text field.
  • Added debounce functionality to handle rapid input of text.
  • Introduced a clear button that appears when text is entered into the field.
  • Implemented a dropdown list of suggestions that appears when 3 or more characters are entered into the text field.
  • Populated the suggestion list with matching addresses and place names from the geoadmin search API.
  • Added functionality to zoom into the map at the selected address or place name from the suggestion list, with a maximum zoom level of 12.
  • Implemented a quick animation for the zoom functionality, with a duration of approximately 100ms.
  • Ensured that the suggestion list disappears when the search input is cleared.

Technical Details:

This functionality relies on the geoadmin provider from the geospatial-sdk, specifically the queryGeoadmin function.
https://github.com/camptocamp/geospatial-sdk

Screenshots

image

image

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added

#756

@ronitjadhav ronitjadhav requested a review from jahow February 2, 2024 16:52
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Affected libs: feature-map, feature-dataviz, feature-record, feature-router, data-access-datafeeder, api-metadata-converter, feature-editor, feature-search, api-repository, feature-catalog, feature-auth, ui-search, util-data-fetcher, util-app-config, data-access-gn4, common-fixtures, ui-elements, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-map, common-domain, ui-dataviz, ui-layout, util-i18n,
Affected apps: map-viewer, metadata-editor, datahub, demo, webcomponents, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 84.014% (-2.3%) from 86.363%
when pulling 2327832 on mv-geocoding
into 4664346 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, well done!

@ronitjadhav ronitjadhav merged commit 42331d6 into main Feb 6, 2024
8 checks passed
@ronitjadhav ronitjadhav deleted the mv-geocoding branch February 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants