Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support services: correctly wait for records to be indexed, add INSPIRE thesaurus #785

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Feb 1, 2024

Description

This PR brings some improvements to the support-services docker composition:

  • The init service will now correctly wait for all records to be indexed before ending; I suspect this was the cause of some e2e tests flakyness
  • An error was showing up when using a GeoNetwork version above 4.2.2, this has been fixed
  • The GeoNetwork instance will now be bootstrapped with GEMET and Inspire thesauri

Extracted from #782

Also added an E2E test to check that the list of downloads from a WFS is complete, following #786

Architectural changes

none

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Swisstopo/Geocat.ch.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

jahow added 3 commits February 1, 2024 17:52
Also fix an issue where jq would be missing for GN > 4.2.2 in the init script
The intercept calls were placed after the visit() call to avoid race conditions
where the fixtures were sometimes not used
@jahow jahow force-pushed the improve-docker-comp-init branch from 768747d to f23683b Compare February 1, 2024 17:37
@coveralls
Copy link

Coverage Status

coverage: 86.363% (+3.3%) from 83.112%
when pulling f23683b on improve-docker-comp-init
into aecf190 on main.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jahow jahow merged commit 4664346 into main Feb 1, 2024
8 checks passed
@jahow jahow deleted the improve-docker-comp-init branch February 1, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants