-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datahub] [Redesign] Licence and usages panel #778
Conversation
Affected libs:
|
cf015ef
to
426d023
Compare
oups sorry i clicked on the "ready for review" button by accident 🙃 |
9b53c5d
to
d0ca679
Compare
Refined the layout for the License and Condition panels, now distinctly sectioned as follows:
Implemented gnUiLinkify for all licenses, legal and other constraints, enabling URLs to be opened in new tabs, improving accessibility and user interaction. Screenshot: |
Thanks @ronitjadhav, is it ready for a review ? |
@fgravin the changes in the metadata model affects the metadata-converter app which needs to be adjusted, but (correct if me if I'm wrong @ronitjadhav) this is ready for review, yes; note that this was in part done in pair-programming with me |
@ronitjadhav I've added a few commits to get closer to the mockup & improve the HTML template. The md-converter app is now also working. @fgravin feel free to make a review! thanks |
The term constraint is now used everywhere instead of "limitations" All constraints are expressed using the same model
+ some renaming for clarification
259bbe7
to
ac494b9
Compare
I have adjusted the constraints to use |
WIP
Description
This PR introduces changes for the redesign of the licence and usages panel. It includes the following changes :
Screenshots
Quality Assurance Checklist
This work is sponsored by GeoCat.