Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] [Redesign] Licence and usages panel #778

Merged
merged 13 commits into from
Mar 9, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jan 22, 2024

WIP

Description

This PR introduces changes for the redesign of the licence and usages panel. It includes the following changes :

  • Rename the existing panel and move it to the first place
  • change the style of the usage conditions
  • show usage limitations separately
  • improve the mapper to better split the licenses, restrictions and conditions (it gets mixed up sometimes)

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new user stories 🤏 are introduced: E2E tests were added
  • The documentation website 📚 has received the love it deserves

This work is sponsored by GeoCat.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Affected libs: api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, feature-editor, ui-search, common-domain, common-fixtures, ui-elements, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@ronitjadhav ronitjadhav force-pushed the DH/redesign-licence-usage-panel branch from cf015ef to 426d023 Compare February 14, 2024 08:19
@fgravin fgravin marked this pull request as ready for review February 15, 2024 11:25
@fgravin
Copy link
Member

fgravin commented Feb 15, 2024

oups sorry i clicked on the "ready for review" button by accident 🙃

@coveralls
Copy link

coveralls commented Feb 15, 2024

Coverage Status

coverage: 83.323% (-2.9%) from 86.195%
when pulling ac494b9 on DH/redesign-licence-usage-panel
into cbcafed on main.

@ronitjadhav ronitjadhav force-pushed the DH/redesign-licence-usage-panel branch from 9b53c5d to d0ca679 Compare February 25, 2024 08:33
@ronitjadhav
Copy link
Collaborator

Refined the layout for the License and Condition panels, now distinctly sectioned as follows:

  • Licenses: Displayed first, where each license with a URL is clickable for direct access.
  • Legal Constraints: Positioned after licenses, presented without a specific title to maintain a seamless flow.
  • Other Constraints: Listed under "Additional conditions," enhancing the structured presentation of information.

Implemented gnUiLinkify for all licenses, legal and other constraints, enabling URLs to be opened in new tabs, improving accessibility and user interaction.

Screenshot:

image

@fgravin
Copy link
Member

fgravin commented Feb 27, 2024

Thanks @ronitjadhav, is it ready for a review ?

@jahow
Copy link
Collaborator

jahow commented Feb 27, 2024

@fgravin the changes in the metadata model affects the metadata-converter app which needs to be adjusted, but (correct if me if I'm wrong @ronitjadhav) this is ready for review, yes; note that this was in part done in pair-programming with me

@jahow
Copy link
Collaborator

jahow commented Feb 29, 2024

@ronitjadhav I've added a few commits to get closer to the mockup & improve the HTML template. The md-converter app is now also working.

@fgravin feel free to make a review! thanks

@jahow jahow force-pushed the DH/redesign-licence-usage-panel branch from 259bbe7 to ac494b9 Compare March 9, 2024 15:11
@jahow
Copy link
Collaborator

jahow commented Mar 9, 2024

I have adjusted the constraints to use gn-ui-markdown-parser, so that the constraints can actually contain rich text (line breaks, lists etc.). This is now finished IMO, I will merge when green.

@jahow jahow merged commit 6695ae4 into main Mar 9, 2024
9 checks passed
@jahow jahow deleted the DH/redesign-licence-usage-panel branch March 9, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants