Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Fix organisation search to work with pagination #753

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jan 8, 2024

Currently, organisation search results are not displayed once the user navigates to a page > 1. This PR ensures displaying the search results by going back to the first page. The pagination is not impacted when changing sort order.

Bug before the fix:
org_filter_paginate

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Affected libs: feature-catalog, feature-record, feature-router, ui-elements, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.421% (+0.03%) from 86.396%
when pulling fb45908 on org-search-paginate
into 173df65 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch, thanks!!

@tkohr tkohr merged commit 5281d0d into main Jan 9, 2024
7 checks passed
@tkohr tkohr deleted the org-search-paginate branch January 9, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants