Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datahub] Fix : add missing tooltip #752

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[Datahub] Fix : add missing tooltip #752

merged 1 commit into from
Jan 8, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jan 8, 2024

This PR adds a tooltip for the gn-ui-link-cards and gn-ui-api-cards, to display titles that are too long for the cards.

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.481% (+0.09%) from 86.396%
when pulling 3387d14 on DH/add-tooltip-cards
into 173df65 on main.

jahow
jahow approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 🙏

@cmoinier cmoinier merged commit 3632b8b into main Jan 8, 2024
7 checks passed
@cmoinier cmoinier deleted the DH/add-tooltip-cards branch January 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmoinier @coveralls @jahow