-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sponsor by MEL] Add feature Metadata Quality Widget #497
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,10 +58,12 @@ export interface BaseRecord { | |
keywords: Array<string> // TODO: handle thesaurus and id | ||
accessConstraints: Array<AccessConstraint> | ||
useLimitations: Array<string> | ||
legalConstraints?: Array<string> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know what to think with these changes, you are updating the pivot format which has been carefuly designed from various standards. I let @jahow judge, maybe those properties were missing. BTW How do we manage There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. legal constraints are There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Topics and themes are semantically the same thing I would say. In ISO they are in two different places but we can probably append them together in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jahow legalConstraints doesn't go to accessConstraints, it go to useLimitations which is a string Array. The field is MD_LegalConstraintsUseLimitationObject There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jahow Des nouvelles sur le sujet? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gkeimeHDF sorry for taking so long to answer. It's a tricky subject, I think we can leave it like that and improve it later on. Thanks! |
||
licenses: Array<License> | ||
overviews: Array<GraphicOverview> | ||
extras?: Record<string, unknown> | ||
landingPage?: URL | ||
updateFrequency?: UpdateFrequency | ||
|
||
// to add: iso19139.topicCategory | ||
// to add: canonical url | ||
|
@@ -136,7 +138,6 @@ export interface DatasetRecord extends BaseRecord { | |
kind: 'dataset' | ||
contactsForResource: Array<Individual> | ||
status: RecordStatus | ||
updateFrequency: UpdateFrequency | ||
datasetCreated?: Date | ||
datasetUpdated?: Date | ||
lineage: string // Explanation of the origin of this record (e.g: how, why)" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is redundant with
FIELDS_SUMMARY
.I think that
ES_SOURCE_SUMMARY
should be removed, what do you think @jahow .@gkeimeHDF it's not your responsability, but I don't think that you need this change, as this constant is just used in the
related records
request.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no big deal, there's probably some more cleanup to do but that doesn't have to be part of this PR; I'm fine either way