Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM package] Add missing peer dependency #1079

Closed
wants to merge 1 commit into from
Closed

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jan 17, 2025

Description

PR adds url to package as a dependency, which is needed by the peer dependency rdflib => @frogcat/ttl2jsonld, but which is not included in the package-lock for some reason. This breaks the app build downstream.

In gn-ui url is already present via @storybook/builder-webpack5.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@tkohr
Copy link
Collaborator Author

tkohr commented Jan 17, 2025

As this is a known issue, that may potentially be fixed soon, I'll close this PR here and temporarily install the missing dependency downstream.

@tkohr tkohr closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant