-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DH][IGN] : Quality score widget stuck at 87% #1076
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this makes a lot of sense! do you think you could check that the same text does not appear twice in the metadata-info block in the e2e tests? Maybe modify a record to have the same text in licenses and legalConstraints, and then make sure it only appears once on the record page
Noted and will do, I'm currently writing the tests :) We already have a few records that have this issue so no need to modify one I think |
dbce04c
to
a2431d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the tests! This fixes one part of the issue yes. The other part (wrong quality scores coming from the index) will be done in a separate PR.
Description
What the issue was
The issue was that a filtering was done during the field mapping to remove any legal constraint that was also present in the licenses, to avoid having duplicates displayed. Since some records only have a legal constraint that happens to be a license, the array ends up empty.
Fix
The filtering was removed from the mapping and placed in a display component.
What issues remain
This PR fixes the behavior of the quality score widget specifically for IGN.
The backend still returns a wrong value for the quality score, which is taken instead of the one calculated by the front-end.
The IGN platform doesn't have a value returned for that field, which means that this fix will work on their platform (to test on our platform, we can simulate an empty value here).
With this fix, all of our records that should be displaying a score of 100% will still show 87% with all indicators checked (like on the geo2france platform).
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThanks @AlitaBernachot for the help on this 🙂