Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Display notifications always on top #1060

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Dec 11, 2024

Description

This PR raises z-index of div around notifications-container to make sure they are always displayed on top (including hovered buttons).

Commit related to the issue (that may be needed for other cases?) : 4ac94ad

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

to make sure they are always displayed on top (including hovered buttons)
Copy link
Contributor

Affected libs: ``,
Affected apps: metadata-editor,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 84.986% (+1.3%) from 83.736%
when pulling 00ae4a2 on me-notifications-on-top
into 48c95d3 on main.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

📷 Screenshots are here!

@tkohr tkohr changed the title fix(notifications): raise z-index of div around notifications-container Editor: Display notifications always on top Dec 11, 2024
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :) the z-index of hovered/active buttons was raised to 10 so that buttons' outlines appear above others in that case, so we have to keep it I think

@tkohr
Copy link
Collaborator Author

tkohr commented Dec 11, 2024

Alright, thanks for the info @jahow !

@tkohr tkohr merged commit af826c8 into main Dec 11, 2024
13 checks passed
@tkohr tkohr deleted the me-notifications-on-top branch December 11, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants