-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ME]: Trying to upload the same file as a resource or attachment twice fails #1009
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, thank you! I think the logic is perfect. In terms of implementation, I think we can achieve less repetition and better test coverage, see my remarks! Let me know if anything is unclear.
...lib/components/record-form/form-field/form-field-overviews/form-field-overviews.component.ts
Outdated
Show resolved
Hide resolved
...rm/form-field/form-field-online-link-resources/form-field-online-link-resources.component.ts
Outdated
Show resolved
Hide resolved
...lib/components/record-form/form-field/form-field-overviews/form-field-overviews.component.ts
Outdated
Show resolved
Hide resolved
7c1883e
to
461f4d6
Compare
check if file name already exist and rename if that s the case before uploading
461f4d6
to
34a5484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Description
This PR fixes the overview and online resources file upload by checking if the filename already exists and renaming it if necessary.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label**This work is sponsored by **.