feat(geom-filter): add tests

geonetwork · Nov 29, 2023 · 69c9d3f · 69c9d3f
1 parent 650eab0
commit 69c9d3f
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/libs/feature/search/src/lib/state/effects.spec.ts b/libs/feature/search/src/lib/state/effects.spec.ts
@@ -444,6 +444,45 @@ describe('Effects', () => {
             })
           )
         })
+        describe('when geometry is broken', () => {
+          beforeEach(() => {
+            effects['filterGeometry$'] = of({
+              type: 'Polygon',
+              coordinates: [[]],
+            })
+            effects = TestBed.inject(SearchEffects)
+            actions$ = of(new RequestMoreResults('main'))
+          })
+          it('skips the geometry in the search', async () => {
+            await firstValueFrom(effects.loadResults$)
+            expect(repository.search).toHaveBeenCalledWith(
+              expect.not.objectContaining({
+                filterGeometry: { type: 'Polygon', coordinates: [[]] },
+              })
+            )
+          })
+        })
+        describe('when geometry is invalid', () => {
+          beforeEach(() => {
+            effects['filterGeometry$'] = of({
+              type: 'Polygon',
+              coordinates: [
+                [0, 1],
+                [0, 1],
+              ],
+            }) as any
+            effects = TestBed.inject(SearchEffects)
+            actions$ = of(new RequestMoreResults('main'))
+          })
+          it('skips the geometry in the search', async () => {
+            await firstValueFrom(effects.loadResults$)
+            expect(repository.search).toHaveBeenCalledWith(
+              expect.not.objectContaining({
+                filterGeometry: { type: 'Polygon', coordinates: [[]] },
+              })
+            )
+          })
+        })
       })
       describe('when useSpatialFilter is disabled', () => {
         beforeEach(() => {

diff --git a/libs/feature/search/src/lib/state/effects.ts b/libs/feature/search/src/lib/state/effects.ts
@@ -146,7 +146,7 @@ export class SearchEffects {
               map((geom) => [state, favorites, geom]),
               catchError((e) => {
                 return of([state, favorites, null])
-              }) // silently opt out of spatial filter if an error happens
+              })
             )
           }),
           switchMap(