Merge pull request #818 from geonetwork/carousel-dots

chore(carousel): Remove dot from carousel component if less than 2 dots
geonetwork · Mar 22, 2024 · 4434d8e · 4434d8e
2 parents 91cd6a9 + 752cd05
commit 4434d8e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts b/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts
@@ -472,6 +472,16 @@ describe('dataset pages', () => {
           .find('gn-ui-api-card')
           .should('have.length.gt', 0)
       })
+      it('should not display carousel dot button for 4 link cards', () => {
+        cy.get('datahub-record-otherlinks')
+          .find('.carousel-step-dot')
+          .should('exist')
+      })
+      it('should not display carousel dot button for 2 API cards', () => {
+        cy.get('datahub-record-apis')
+          .find('.carousel-step-dot')
+          .should('not.exist')
+      })
     })
     describe('features', () => {
       it('goes to external link on click', () => {

diff --git a/libs/common/fixtures/src/lib/records.fixtures.ts b/libs/common/fixtures/src/lib/records.fixtures.ts
@@ -240,5 +240,6 @@ Ce lot de données produit en 2019, a été numérisé à partir du PCI Vecteur
     temporalExtents: [],
     status: 'completed',
     updateFrequency: 'unknown',
+    languages: ['fr', 'de'],
   },
 ])
diff --git a/libs/ui/layout/src/lib/carousel/carousel.component.html b/libs/ui/layout/src/lib/carousel/carousel.component.html
@@ -4,6 +4,7 @@
   </div>
 </div>
 <div
+  *ngIf="steps.length > 1"
   class="absolute right-0 top-0 flex flex-row justify-center gap-[10px] p-1"
   [ngClass]="stepsContainerClass"
 >
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,7 @@ @@
       </div>
     </div>
     <div
+      *ngIf="steps.length > 1"
       class="absolute right-0 top-0 flex flex-row justify-center gap-[10px] p-1"
       [ngClass]="stepsContainerClass"
     >
@@ Expand Down @@