Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to improve the build speed of the JS. #103

Conversation

theduckylittle
Copy link
Member

Trying to make fire.

@klassenjs
Copy link
Member

klassenjs commented May 31, 2017

grunt build hangs on Win7 in webpack:build-dev at 61% 390/456 build modules.

0% CPU usage, no disk, usage, plenty of free memory. This seems to match what was reported at amireh/happypack#70.

Where exactly it stops seems non-deterministic. I have a slight feeling of deja-vu with this and a node.js synchronization bug, but I can't remember what/where it was.

@theduckylittle
Copy link
Member Author

As we're basically ignoring the source maps for "index" right now, maybe we just drop building that. It saves quite a bit of time on the build-deploy. That alone might make the process less onerous.

@klassenjs
Copy link
Member

I am curious how much time and RAM that would save.

It would be cool if the source maps worked in production for debugging, but I have never figured them out (maybe a Firefox thing). So what I am trying to say is right now I wouldn't notice their absence.

@klassenjs
Copy link
Member

Note: It looks like UglifyJS uses the source map in deploy to give line numbers in errors/warnings.

@theduckylittle
Copy link
Member Author

closing for further research elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants