Fixed typos, language, and clarified interior/exterior rule #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interior rings must fall within the geometry of the exterior ring, not just the convex hull of the exterior ring.
|
@sdrees Hold on, let's have a little more discussion before we merge these. I didn't merge my own (#1) directly because I was looking for more comment first. On this particular issue, I remember that we had consensus (back in the day) to keep issues of geometric validity out of the spec. Can we just explain what validity means without requiring geometries to be valid? |
|
Agreed. This makes it impossible to have a service that validates geometry and use GeoJSON as the transport. |
|
Fine by me to remove all the geometry validity language; not fine for it to be there and be wrong. Martin |
This was referenced May 15, 2013
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interior rings must fall within the geometry of the exterior ring, not just the convex hull of the exterior ring.