Single file copies of our GeoJSON examples are now rendered nicely on Github #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger the new GeoJSON display rendering on github
|
Looks good @sdrees. Please merge. |
|
I'm okay with a merge, though it might be good to alter the values in these examples so that they overlay interesting map data and fall within range of Leaftlet zoom levels. |
|
@sgillies - agreed. Was going to address that in a separate PR. |
|
Am 17.06.13 20:25, schrieb Tim Schaub:
so I merge and Tim adds beauty to the awsomeness ;-?) Stefan. |
sthagen
pushed a commit
that referenced
this pull request
Jun 17, 2013
…awesomeness Single file copies of our GeoJSON examples are now rendered nicely on Github
|
@tschaub: All set with the awsomeness, now for the beauty 👍 ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply renamed the .js single file copies of the I-D submission candidates GeoJSON examples into .geojson files, so that we all have a taste of the new GeoJSON awsomeness when we browse the js folder in our github repo.
Kudos from me to Tim for reminding me once again, how cool git (and hg are) and how deep the viral patterns of svn induced branch laziness really invaded my brain ;-)
Hope you like it. Don't expect all samples to cause stunning display effects. Some may even result in a cannot render message.
All the best,
Stefan.