Complete review of ed2 #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏻 still work in progress (probably for another week or two) |
|
Thanks for this Jakub, just spotted! |
Robinlovelace
approved these changes
Dec 5, 2023
| In late 2021, the planned retirement of **rgdal**, **rgeos** and **maptools** was announced on [the R-sig-Geo mailing list](https://stat.ethz.ch/pipermail/r-sig-geo/2021-September/028760.html) by Roger Bivand. | ||
| This retirement at the end of 2023 has had a large impact on existing workflows applying these packages, but also will influence the packages that depend on them. | ||
| This retirement at the end of 2023 has had a large impact on existing workflows applying these packages, but also [influenced the packages that depend on them](https://geocompx.org/post/2023/rgdal-retirement/). |
There was a problem hiding this comment.
Great addition and good to link to the blog post.
01-introduction.Rmd
Outdated
| @@ -317,23 +313,23 @@ The initial release supported only raster drivers but subsequent enhancements pr | |||
| Many of these additional capabilities were developed by Barry Rowlingson and released in the **rgdal** codebase in 2006 [see @rowlingson_rasp:_2003 and the [R-help](https://stat.ethz.ch/pipermail/r-help/2003-January/028413.html) email list for context]. | |||
|
|
|||
| **sp**, released in 2005, overcame R's inability to distinguish spatial and non-spatial objects [@pebesma_classes_2005]. | |||
| **sp** grew from a [workshop](http://spatial.nhh.no/meetings/vienna/index.html) in Vienna in 2003 and was hosted at sourceforge before migrating to [R-Forge](https://r-forge.r-project.org). | |||
| **sp** grew from a workshop in Vienna in 2003 and was hosted at SourceForge before migrating to [R-Forge](https://r-forge.r-project.org). | |||
There was a problem hiding this comment.
I think where it's hosted is of limited use/interest.
There was a problem hiding this comment.
We can remove the link to the legacy r-forge website and shorten this bit I think.
|
|
||
| ```{r} | ||
| # eval: false | ||
| install.packages("tmap", repos = c("https://r-tmap.r-universe.dev", |
There was a problem hiding this comment.
Would be good to use the CRAN version when tmap 4 released.
There was a problem hiding this comment.
True, but it probably won't happen before the end of the year...
Co-authored-by: Robin Lovelace <[email protected]>
|
Great work Jakub. Merging... |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
* updates cranlogs fig * improves ch1 * updates bib * addds missing refs * updates refs * removes old text * updates vector ch2 * completes ch2 updates * cleans code * improves style * improves ch3 intro * improves ch3 * improves de9im fig * improves spatial join fig * unifies style * unifies style * cleans ch4 * updates 2163 to 9311 * improves ch5 * improves ch6 * improves ch7 * updates vect * improves 08 * improves 09 * fixes code * standardized style GRASS GIS * improves ch10 * improves ch11 * improves ch12 and some general style * fixes style * improves ch13 * improves ch14 * improves ch15 * improves ch16 * relates to #754 * fixes urls * adds new url * adds new footnotes * adds OGC:CRS84 * improves st_buffer * updates toc * Clarify + shorten scentence * removes url * Update 01-introduction.Rmd Co-authored-by: Robin Lovelace <[email protected]> --------- Co-authored-by: Robin Lovelace <[email protected]> 7463cc7
|
Thanks @Robinlovelace ! |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.