Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves ch08 #1121

Merged
merged 1 commit into from
Sep 24, 2024
Merged

improves ch08 #1121

merged 1 commit into from
Sep 24, 2024

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented Sep 24, 2024

No description provided.

@Nowosad Nowosad mentioned this pull request Sep 24, 2024
19 tasks
Copy link
Collaborator

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, keep them coming!

Reading and writing from and to these file formats is covered in Sections \@ref(data-input) and \@ref(data-output), respectively.
In terms of where to *find* data, Section \@ref(retrieving-data) describes *geoportals* and how to import data from them.
Dedicated packages to ease geographic data import, from sources including OpenStreetMap, are described in Section \@ref(geographic-data-packages).
If you want to put your data 'into production' in web services (or if you want be sure that your data adheres to established standards), geographic metadata is important, as described in Section \@ref(geographic-metadata).
If you want to put your data 'into production' in web services (or if you want to be sure that your data adheres to established standards), geographic metadata is important, as described in Section \@ref(geographic-metadata).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definite typo fix. They are good!

@@ -50,7 +50,7 @@ plot(germany_borders)
st_write(germany_borders, "germany_borders.gpkg")
```

E5. Download the global monthly minimum temperature with a spatial resolution of five minutes using the **geodata** package.
E5. Download the global monthly minimum temperature with a spatial resolution of 5 minutes using the **geodata** package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this? Not consistent with previous change from 8 to eight, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the case I mentioned to you last week in Prague. I have zero idea why...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal either way... "5" is shorter so would advocate for that throughout. Not pedantic enough to care, that much...

@Robinlovelace Robinlovelace merged commit 2b521e5 into main Sep 24, 2024
0 of 3 checks passed
@Robinlovelace Robinlovelace deleted the ch08-proofread branch September 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants