Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Geocoder v3 and register named providers #39

Closed
wants to merge 9 commits into from
Closed

Update to Geocoder v3 and register named providers #39

wants to merge 9 commits into from

Conversation

ilyashtrikul
Copy link

  • According to

Major version 2 will reach end of life on December 2015

needs to update Geocoder version in composer.json.

  • We can configure only chain provider. With my fix we can register named providers (and chain too), and call them with Geocoder::using('provider_name').

@toin0u
Copy link
Member

toin0u commented Jan 28, 2016

@shtricul Thank you. It looks good. Can you update the doc as well please? :)

@dccampbell
Copy link

So...has this change been held back for over a half year just for documentation? If it's fully functional, any chance of getting it merged in? Or maybe start a release branch to pull in other updates as well and encourage doc updates before merging to master and tagging a release? cc @toin0u @shtricul

@mikebronner
Copy link
Member

Thanks for this PR ... we are implememting an update to Geocoder v3.3.x and should have it out shortly. Closing this PR for now, as things have changed somewhat and we have another similar PR in the works. Thanks for your efforts though, please continue submitting PRs if you see something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants