Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: Refactor table readers #594

Open
5 of 11 tasks
kylebarron opened this issue Apr 3, 2024 · 2 comments
Open
5 of 11 tasks

EPIC: Refactor table readers #594

kylebarron opened this issue Apr 3, 2024 · 2 comments

Comments

@kylebarron
Copy link
Member

kylebarron commented Apr 3, 2024 •
edited
Loading

The order listed here is not necessarily the best order of work.

  • Set up Rust monorepo with multiple crates
  • Create geoarrow-io crate. Move existing IO functionality into that crate. This should vastly simplify the dependencies in the main geoarrow crate.
  • Refactor type signatures of readers and writers. The goal here is to decouple the readers from the GeoTable concept. It should also improve functionality with streaming operations and support future integration with Datafusion.
  • Refactor writers to accept a RecordBatchReader.
  • Refactor GeoTable to Table, remove a hard-coded geometry column index. Note that this is not necessary for the initial parsing as long as you're able to convert the RecordBatchReader into a GeoTable.
@kylebarron kylebarron pinned this issue Apr 3, 2024
@kylebarron kylebarron mentioned this issue Apr 3, 2024
Merged
2 tasks
@kylebarron
Copy link
Member Author

Python geoarrow-rust-io submodule

@kylebarron kylebarron mentioned this issue Apr 3, 2024
Merged
kylebarron added a commit that referenced this issue Apr 4, 2024
@kylebarron
Refactor table to allow multiple/no geometry columns (#599)
9033a39 
For #594
@kylebarron kylebarron changed the title EPIC: Refactor table readers and 3D array support EPIC: Refactor table readers Jul 18, 2024
@kylebarron
Copy link
Member Author

Splitting this into two epics, with 3d support in #662

@kylebarron kylebarron mentioned this issue Dec 11, 2024
Merged
kylebarron added a commit that referenced this issue Dec 11, 2024
@kylebarron
Return RecordBatchReader in CSV read API (#931)
398d9d9 
For #594, for
#596.
@kylebarron kylebarron mentioned this issue Dec 11, 2024
Merged
1 task
kylebarron added a commit that referenced this issue Dec 23, 2024
@kylebarron
feat(io): Convert FlatGeobuf reader to RecordBatchReader iterator (#933)
9a1e946 
This PR updates the FlatGeobuf reader (the sync version only for now) to
expose data as an iterator. This means that applications like Python can
access data larger than memory, and process it in batches.

- [x] This was blocked on Flatgeobuf exposing the `Seekable` and
`NotSeekable` marker structs, but that happened in
flatgeobuf/flatgeobuf#402

Closes #932

For #594, for
#596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylebarron