-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-1157 Add hreflang to Links #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-1157-hreflang
branch
3 times, most recently
from
December 5, 2024 14:59
41753d8
to
2821861
Compare
schtibe
force-pushed
the
feat-pb-1157-hreflang
branch
2 times, most recently
from
December 9, 2024 13:16
ce2e9df
to
ebd0ba3
Compare
boecklic
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks! 👍
asteiner-swisstopo
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like how test coverage was improved with this. A few side comments mainly to possibly improve maintainability.
schtibe
force-pushed
the
feat-pb-1157-hreflang
branch
2 times, most recently
from
December 12, 2024 10:32
cb489d7
to
1938f2d
Compare
schtibe
force-pushed
the
feat-pb-1157-hreflang
branch
from
December 12, 2024 10:41
1938f2d
to
4e3decb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the extension field
hreflang
to the fields of the Links.