Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1157 Add hreflang to Links #483

Merged
merged 6 commits into from
Dec 12, 2024
Merged

PB-1157 Add hreflang to Links #483

merged 6 commits into from
Dec 12, 2024

Conversation

schtibe
Copy link
Contributor

@schtibe schtibe commented Dec 5, 2024

Adding the extension field hreflang to the fields of the Links.

@schtibe schtibe force-pushed the feat-pb-1157-hreflang branch 3 times, most recently from 41753d8 to 2821861 Compare December 5, 2024 14:59
@schtibe schtibe force-pushed the feat-pb-1157-hreflang branch 2 times, most recently from ce2e9df to ebd0ba3 Compare December 9, 2024 13:16
Copy link
Contributor

@boecklic boecklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 👍

Copy link
Contributor

@asteiner-swisstopo asteiner-swisstopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like how test coverage was improved with this. A few side comments mainly to possibly improve maintainability.

app/tests/tests_10/test_collections_endpoint.py Outdated Show resolved Hide resolved
app/stac_api/models.py Outdated Show resolved Hide resolved
spec/components/schemas.yaml Outdated Show resolved Hide resolved
app/stac_api/admin.py Outdated Show resolved Hide resolved
@schtibe schtibe force-pushed the feat-pb-1157-hreflang branch 2 times, most recently from cb489d7 to 1938f2d Compare December 12, 2024 10:32
@schtibe schtibe force-pushed the feat-pb-1157-hreflang branch from 1938f2d to 4e3decb Compare December 12, 2024 10:41
@schtibe schtibe merged commit 0bbbf34 into develop Dec 12, 2024
3 checks passed
@schtibe schtibe deleted the feat-pb-1157-hreflang branch December 12, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants