Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Cesium update to 1.48 #4502

Closed
wants to merge 2 commits into from
Closed

Cesium update to 1.48 #4502

wants to merge 2 commits into from

Conversation

gjn
Copy link
Contributor

@gjn gjn commented Sep 20, 2018

Update Cesium from 1.44 to 1.48.

Testlink with prod backends

@gjn
Copy link
Contributor Author

gjn commented Sep 20, 2018

It doesn't work on Edge as the same error is produces as described in #4358.

The testlink from the ol5_migration i sent out this week was workign in Edge 41, but, but, but, ol5_migration branch is still using Cesium 1.44 (and not 1.48 or newer). So we actually tested only the ol5 version, but not a new cesium version.

This means for the go-live next week, we have to live with Cesium 1.44...

@davidoesch
Copy link
Contributor

Ahhh ... This is real PITA. ... And since approx 50% visits is BV internally ( this was the case couple years ago according to moc) we can't just ignore EDGE 41. What about : detecting browser and loading different version of cesium

@gjn
Copy link
Contributor Author

gjn commented Sep 20, 2018

Possible, quite some work. Bad weekend. Maybe I find time next Monday.

@gjn
Copy link
Contributor Author

gjn commented Sep 20, 2018

ok. try now loading 1.44 in Edge < 41. Loading 1.48 in all other browsers. but:

  1. some assets (json, js, etc) are mixed (1.44 loads assets from 1.48 - 1.48 should be fine). So Edge 41 might be worst than current prod, please test well.
  2. NOT tested on Edge 42
  3. NOT tested on Firefox
  4. KML is not tested

If we want this on prod, this needs good testing.

Edit: BTW, i got the blank screen sometimes when loading in Edge. I think it's happening sometimes when laptop is running on battery. When laptop is in docking station, I never had it.

@davidoesch
Copy link
Contributor

davidoesch commented Sep 21, 2018

private of the shelf win10 machine:
EDGE 42

FF 61 64bit

ALL browsers

  • https://mf-chsdi3.int.bgdi.ch/shorten/7d262879df u see names behind the hills (not the case in current prod)

  • time stamp layers LFHK is visible even if not active

  • when multiple browser windows in 3d are open: GPU fails and warning is issued (3d mode) in chrome ff and EDGE. so we might add a warning: 3d mode: close all other browser windows

conclusio:

  • EDGE 42 is a huge improvement imho we need such a fix

next step:

@pauloamado
Copy link
Contributor

Link tested :
Google Chrome 69 with external wlan : good performance
Microdoft Edge 42 with external wlan : medium-good performance
Microdoft Edge 41 with external wlan : bad performance
(worse than 41 with external wlan and current prod version)

@Sgachet
Copy link
Contributor

Sgachet commented Sep 25, 2018

In general, the different tests succeed but ...

Ipad (Safari) with intern wlan : bad performance (sometimes the webpage must be reloaded)
Ipad (Safari) with external wlan : bad/medium performance (worse than the current prod version)
Surface with intern wlan : medium performance

Edge 41 with intern wlan : bad / medium performance

@gjn gjn mentioned this pull request Sep 26, 2018
@danduk82
Copy link
Contributor

no-go

@danduk82 danduk82 closed this Oct 10, 2018
@pakb pakb deleted the gjn_cesium_update branch February 8, 2019 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants