[WIP] Remove globals from api loader #956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder to self: prod mode uses ga-whitespace...can't correct now because mf0t is read-only :) |
|
Don't you think we could put all the content of js files in the loader.js ? with that we can get rid of the doucment.write statements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this
This applies geoadmin/ol3#106 as ol3.
It adapts the loader to remove the need to define the GeoAdmin global variables. It removes the ol3-install and ol3-serverconfig targets (they are not needed).
It works in almost all browsers I testet...only IE9 doesn't work. IE9 does not execute the document.write statements synchronously, so the loader fails. Did not find a workaround yet...