-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cram support #609
Open
zlskidmore
wants to merge
7
commits into
genome:master
Choose a base branch
from
zlskidmore:cram_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cram support #609
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
16fd13f
initial test of cram support
zlskidmore 99f1ffb
fix scatter
zlskidmore 4060496
fix typos
zlskidmore 0b793a4
fixed another typo
zlskidmore c7ef29f
forgot the -T prefix for samtools
zlskidmore 3181f61
removed uneccessary file
zlskidmore 1bc747a
bumped java heap space
zlskidmore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
#!/usr/bin/env cwl-runner | ||
|
||
class: CommandLineTool | ||
|
||
cwlVersion: v1.0 | ||
|
||
baseCommand: [ "samtools", "view" ] | ||
|
||
requirements: | ||
- class: DockerRequirement | ||
dockerImageId: zlskidmore/samtools:1.9 | ||
dockerPull: zlskidmore/samtools:1.9 | ||
- class: ResourceRequirement | ||
ramMin: 20000 | ||
coresMin: 8 | ||
|
||
arguments: | ||
- valueFrom: "8" | ||
position: 1 | ||
prefix: "--threads" | ||
- valueFrom: "file.bam" | ||
position: 2 | ||
prefix: "-o" | ||
- valueFrom: "-b" | ||
position: 3 | ||
|
||
inputs: | ||
input: | ||
type: File | ||
inputBinding: | ||
position: 5 | ||
cram_reference: | ||
type: File? | ||
inputBinding: | ||
position: 4 | ||
prefix: "-T" | ||
|
||
outputs: | ||
bam_file: | ||
type: File | ||
outputBinding: | ||
glob: file.bam |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
#!/usr/bin/env cwl-runner | ||
|
||
cwlVersion: v1.0 | ||
class: CommandLineTool | ||
label: "Picard: Revert Input" | ||
baseCommand: ["/usr/bin/java", "-Xmx4g", "-jar", "/opt/picard/picard.jar", "RevertSam", "VALIDATION_STRINGENCY=SILENT"] | ||
requirements: | ||
- class: ResourceRequirement | ||
coresMin: 1 | ||
ramMin: 6000 | ||
tmpdirMin: 25000 | ||
- class: DockerRequirement | ||
dockerPull: "mgibio/rnaseq" | ||
arguments: | ||
- valueFrom: "reverted.bam" | ||
position: 2 | ||
prefix: "O=" | ||
|
||
inputs: | ||
bam: | ||
type: File | ||
inputBinding: | ||
prefix: "I=" | ||
separate: false | ||
position: 1 | ||
outputs: | ||
reverted_bam: | ||
type: File | ||
outputBinding: | ||
glob: "reverted.bam" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
instrument_data_bams: | ||
instrument_data: | ||
- class: File | ||
path: gerald_H3MYFBBXX_4_GCCAAT_1k.bam | ||
- class: File | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could
revert_input.cwl
be run on CRAMs directly? If so seems likeinput_to_bam
could be removed. If not, seems like it should be namedrevert_bam.cwl
instead ofrevert_input.cwl
to denote its specificity.(Is this operation time and space-efficient enough that we're willing to do it on all inputs instead of only those that need it?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is the specificity, the tool in revert_input.cwl can be run on anything but you would have to use the input variable, currently bam, to grab the appropriate out file , basically would require some javascript i expect which i try to avoid in cwl. I think renaming to revert_bam.cwl is preferable from my perspective.
The flexibility in the PR does come at a computational cost for sure. I think we should run revert_input.cwl either way though so the cost is just converting whatever input to bam