Special variable references for zeroing internals #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ``CustomUpdateVarAccess``
…elaySlots`` which returns the actual number of delay slots as an optional - tidies up quite a bit of code
…functionality to generate delayed indices in CustomUpdateGroupMerged
…tPost variables don't get initialised
* Mechanism for ensuring custom updates only refernce dendritic delay buffers from one synapse group * Code generation of dendritic delay-based indexing of variable references
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 87.94% 88.29% +0.35%
==========================================
Files 104 106 +2
Lines 13914 14853 +939
==========================================
+ Hits 12237 13115 +878
- Misses 1677 1738 +61 ☔ View full report in Codecov by Sentry. |
…delay synapse groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to zero things like
outPost(inSynin GeNN 4 parlance) on the host between trials slows down simulations with extracudaMemcpyand Python-side processing. This PR adds some extra functionality that lets you move more of this into custom updates and also improves the handling of delayed variables in custom updates:VarAccessMode::BROADCASTandCustomUpdateVarAccess::BROADCAST_DELAYto indicate variables, writes to which are 'broadcast' across all delay slotswriteOnlyflag for value types - these can only be assigned with plain=assignement. Applied to bothVarAccessMode::BROADCASTvariables and also reductions to improve error handling (also, while I was in this code, tightened up some type-checking)outPostanddenDelay.Together, this means you can do all resetting required for delayed EventProp on device.