Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for clang errors and reduced warnings #623

Merged
merged 1 commit into from
May 3, 2024

Conversation

neworderofjamie
Copy link
Contributor

The better fix for the actual compiler error was to add trailing return types -> uint64_t to the lambda functions.

However, the majority of the changes are to fix warnings, mostly:

  • Unused captured lambda parameters
  • Missing virtual destructors in a few base classes
  • A few unused variables of other sorts and a whole unused method

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fix of the actual error is general (not Mac-specific) - nice.

@neworderofjamie
Copy link
Contributor Author

I would suspect it will fix compilation with clang on other platforms as well (and reduce the warnings)

@neworderofjamie neworderofjamie merged commit 98f24cb into master May 3, 2024
3 checks passed
@neworderofjamie neworderofjamie deleted the clang_fix branch May 3, 2024 07:52
@neworderofjamie neworderofjamie added this to the GeNN 5.0.1 milestone Jun 6, 2024
@neworderofjamie neworderofjamie modified the milestones: GeNN 5.0.1, GeNN 5.1.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants