Small constant cache fix #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…free constant cache calculation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
=======================================
Coverage 88.79% 88.80%
=======================================
Files 76 76
Lines 12428 12429 +1
=======================================
+ Hits 11036 11037 +1
Misses 1392 1392
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I fixed a race condition in the system for tracking neuron's previous spike time in #414, I added a new kernel which had an associated new array of indices used for the binary search amongst merged groups. Because of the memory access pattern of the binary search, these take first priority when the 64KB of constant cache is handed out. However, I forgot to take these indices into account, meaning that models with lots of neuron and synapse groups and learning rules using previous spike times could overrun the constant cache.
Fixes #588