Fix batch init #509
Merged
Fix batch init #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 87.03% 81.43% -5.61%
==========================================
Files 84 74 -10
Lines 18108 14916 -3192
==========================================
- Hits 15761 12147 -3614
- Misses 2347 2769 +422
Continue to review full report at Codecov.
|
tnowotny
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing batching I wrote a helper function called
genVariableFillfor initialising variables, taking account of delays and batching. However, for some reason, I forgot to actually use this when initializinginSyn,denDelay(which was subsequently copy-pasted into the initialisation ofrevInSyn). CUDA seems to zero newly allocated memory so, generally, this has minimal effect but, if you reinitialise your model, you may be left with large residual neural input currents in some batch instances (which, if you're using dendritic delays will continue to appear for max dendritic delay timesteps!).This finally fixes the issues we were seeing in Felix Schmitt's model - big thanks to him for testing my various speculative fixes and suggesting that (re-)initialization could be the problem!