Unifying system for applying substitutions #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays called together
* It's not at all clear to me why value_substitution added brackets around substituted values - updated test to no longer expect that
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
===========================================
+ Coverage 41.07% 60.07% +18.99%
===========================================
Files 46 47 +1
Lines 6283 6335 +52
===========================================
+ Hits 2581 3806 +1225
+ Misses 3702 2529 -1173
Continue to review full report at Codecov.
|
tnowotny
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm afraid this is another building block type feature upon which more exciting things can be built. Basically, in GeNN 4 I added the
Substitutionsclass which managed 'individual' substitutions of stuff like "$(id)". However there was stillname_substitutionandvalue_substitutioncalls going on all over the place for model parameters, variables etc and these were implemented with some particularly gnarly C++ I added early in my GeNN career!Having a single unified system for substituting stuff not only tidies stuff up but, in future, could allow us to do stuff like add reference counts meaning that things like #232 #47 and #55 could be addressed in a nicer way that just adding increasingly-complex if clauses around them