-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read only vars #247
Merged
Merged
Read only vars #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove the windows experience a little
…r models where state variables are manually cached in registers
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 85.42% 85.44% +0.02%
==========================================
Files 45 45
Lines 6319 6342 +23
==========================================
+ Hits 5398 5419 +21
- Misses 921 923 +2
Continue to review full report at Codecov.
|
tnowotny
reviewed
Jul 22, 2019
* We were previously using the same ``Var`` struct for extra global params as well where readonlyness is currently meaningless - added separate ``EGP`` struct * Changed boolean for readonly to ``VarAccess`` enum
…nippet::Base`` to ``Models::Base``
…ht update state variables being left out
tnowotny
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to specify whether state variables are readonly when you define a model e.g. in the ``IzhikevichVariable (using syntax similar to that suggested in #55):
Knowing whether state variables are read-only is useful in two ways:
GLOBALG
(this is something that I think is done in the PyNN, SpineML and, I suspect, Brian frontends) or by the long-dreamed-of Izhikevich style re-sampling