Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes matrix checks - looking saner now #76

Merged
merged 3 commits into from
Aug 22, 2017

Conversation

pjotrp
Copy link
Member

@pjotrp pjotrp commented Aug 22, 2017

  • Matrix checks as described in Check matrix properties (5 out of 7 implemented in 0.97) #72
  • introduces -strict switch which will exit on certain conditions
  • zero small eigenvalues in EigenDecomp_Zeroed which also checks for negative values
  • commented out float versions of functions in lapack.cpp (pre-removal)
  • reverted on disabled regression tests (GEMMA shows its previous behaviour now)

- Matrix checks as described in genetics-statistics#72
- introduces -strict switch which will exit on certain conditions
- zero small eigenvalues in EigenDecomp_Zeroed which also checks for negative values
- commented out float versions of functions in lapack.cpp (pre-removal)
- reverted on disabled regression tests (GEMMA shows its previous behaviour now)
@pjotrp pjotrp requested a review from pcarbo August 22, 2017 08:25
@pcarbo pcarbo merged commit 2554242 into genetics-statistics:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants