New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-434 Use file_exists in version check #3

Merged

colanconnon merged 1 commit into master from OP-434-version-file-exists

Dec 13, 2016

Contributor

troyharvey commented Dec 13, 2016

No description provided.


          Use file_exists in version check

c6006e4

troyharvey commented

View reviewed changes

src/HealthVersion.php

                   protected $customPath;
                   /**
                    * HealthVersion constructor.
                    * @param string $customPath
                    */
-                  public function __construct($customPath = __DIR__.'commit.txt')
+                  public function __construct($customPath = __DIR__.'/commit.txt')

Contributor Author

troyharvey Dec 13, 2016

__DIR__ doesn't come with a trailing slash

colanconnon approved these changes

View reviewed changes

colanconnon merged commit d32cc5a into master

colanconnon deleted the OP-434-version-file-exists branch

December 13, 2016 19:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet